On 16/08/2022 21:22, Jeffrey Hugo wrote:
>>>>> + if (datapath_polling) {
>>>>> + poll_datapath = true;
>>>>> + pr_info("qaic: driver initializing in datapath polling mode\n");
>>>>
>>>> No pr() in normal path of init/exit.
>>>
>>> This is not the normal path. datapath_polling is a module parameter.
>>> This is something the user can enable, and so it would be good to have
>>> the user informed that the option took effect.
>>
>> No, not really. User always can check via sysfs and there is no point in
>> polluting dmesg on module load. It might be printed (if someone has such
>> modprobe setting) on every system, even without the actual device.
>
> So, I guess this is limited to platform devices?
> I see GIC, IOMMU, and PCI doing the same
> I guess, will remove.
None of regular drivers should print anything during init/exit. If one
is printing, I think a patch removing it will be accepted.
However you mention platform devices, so a "device" implies probe, not
init. This is a different case.
Best regards,
Krzysztof
