On 09/08/2022 03:03, Rudraksha Gupta wrote:
> This adds a very basic device tree file for the Samsung Galaxy Express
> SGH-I437. Currently, the following things work: UART, eMMC, SD Card, and
> USB.
Use subject prefix matching the subsystem.
>
> Signed-off-by: Rudraksha Gupta <guptarud@xxxxxxxxx>
> ---
> v2:
> - Group the correct changes together
>
> arch/arm/boot/dts/Makefile | 1 +
> .../dts/qcom-msm8960-samsung-expressatt.dts | 337 ++++++++++++++++++
> 2 files changed, 338 insertions(+)
> create mode 100644 arch/arm/boot/dts/qcom-msm8960-samsung-expressatt.dts
>
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index 05d8aef6e5d2..d55f196ad733 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -1049,6 +1049,7 @@ dtb-$(CONFIG_ARCH_QCOM) += \
> qcom-msm8660-surf.dtb \
> qcom-msm8916-samsung-serranove.dtb \
> qcom-msm8960-cdp.dtb \
> + qcom-msm8960-samsung-expressatt.dtb \
> qcom-msm8974-lge-nexus5-hammerhead.dtb \
> qcom-msm8974-sony-xperia-rhine-amami.dtb \
> qcom-msm8974-sony-xperia-rhine-honami.dtb \
> diff --git a/arch/arm/boot/dts/qcom-msm8960-samsung-expressatt.dts b/arch/arm/boot/dts/qcom-msm8960-samsung-expressatt.dts
> new file mode 100644
> index 000000000000..cf557f0c9a59
> --- /dev/null
> +++ b/arch/arm/boot/dts/qcom-msm8960-samsung-expressatt.dts
> @@ -0,0 +1,337 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +#include <dt-bindings/input/input.h>
> +#include "qcom-msm8960.dtsi"
> +
> +/ {
> + model = "Samsung Galaxy S3 SGH-I437";
> + compatible = "samsung,expressatt", "qcom,msm8960";
Undocumented compatible. Run checkpatch.
> +
> + aliases {
> + serial0 = &gsbi5_serial;
> + };
> +
> + chosen {
> + stdout-path = "serial0:115200n8";
> +
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges;
These three properties are confusing. Why adding them?
> + };
> +
> + soc {
> + gsbi@16400000 {
Override by alias.
> + status = "ok";
okay, not ok. Status goes at the end of properties.
> + qcom,mode = <GSBI_PROT_I2C_UART>;
> + serial@16440000 {
> + status = "ok";
Same comments.
> + };
> + };
> +
> + amba {
> + /* eMMC */
> + sdcc1: mmc@12400000 {
OK, I'll abandon the review. This file is really not matching anything
in the upstream. Please start your work from a proper upstreamed, recent
board.
Best regards,
Krzysztof
