On Tue, 2014-10-07 at 10:26 -0700, Dmitry Torokhov wrote: > Hi Ivan, > > On Tue, Oct 07, 2014 at 12:50:46PM +0300, Ivan T. Ivanov wrote: > > @@ -527,10 +538,55 @@ static int pmic8xxx_kp_probe(struct platform_device *pdev) > > > > + > > + kp->row_hold = devm_regmap_field_alloc(kp->dev, kp->regmap, > > + info->row_hold); > > + if (IS_ERR(kp->row_hold)) > > + return PTR_ERR(kp->row_hold); > > Why do we have to allocate all regmap fields separately instead of > embedding them into keypad structure? > No particular reason. Will rework it. Thank you, Ivan > Thanks. > -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html