On Tue, 02 Aug 2022, Satya Priya Kakitapalli (Temp) wrote:
>
> On 7/27/2022 6:49 AM, Stephen Boyd wrote:
> > Quoting Satya Priya Kakitapalli (Temp) (2022-07-21 23:31:16)
> > > regulator-name = "pm8008_l6";
> > > };
> > >
> > > pm8008_l7: ldo7@4600 {
> > > reg = <0x4600>;
> > > regulator-name = "pm8008_l7";
> > > };
> > > };
> > > };
> > >
> > >
> > > Stephen/Mark, Please do let me know if you are OK with this design.
> > >
> > I was happy with the previous version of the DT node. That had one node
> > for the "pm8008 chip", which is important because it really is one
> > package. Why isn't that possible to implement and also register i2c
> > devices on the i2c bus for the second address?
If devices have different addresses, they should have their own nodes, no?
> If we add everything under single DT node i.e., 0x8 device, then, we have to
> use i2c_new_dummy_device() to register 0x9 device, and pass regmap etc to
> child(which Lee is not OK with). Even if I register the regulators as i2c
> devices, I am not sure how we can retrieve the 0x9 regmap in the LDO probe,
> because when I use dev->parent there, it refers to 0x8, as I am adding
> everything under 0x8.
>
>
> To implement what Lee suggested here [1], I will have to add two devices
> separately in the DT.
>
> [V15,6/9] mfd: pm8008: Use i2c_new_dummy_device() API - Patchwork
> (kernel.org) <https://patchwork.kernel.org/project/linux-arm-msm/patch/1655200111-18357-7-git-send-email-quic_c_skakit@xxxxxxxxxxx/#24933901>
--
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
