Hi, On Thu, Jul 28, 2022 at 2:33 PM Bob Moragues <moragues@xxxxxxxxxxxx> wrote: > > Zoglin is a Hoglin Chromebook with SPI Flash reduced from 64MB to 8MB. > Zoglin is identical to Hoglin except for the SPI Flash. > The actual SPI Flash is dynamically probed at and not specified in DTS. > > Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx> > Acked-by: Rob Herring <robh@xxxxxxxxxx> > Signed-off-by: Bob Moragues <moragues@xxxxxxxxxxxx> A nit from my point of view is that I would have expected your Signed-off-by to be the first tag. As I understand it the tags are usually supposed to be a top-to-bottom history of what happened. You signed off on the patch and then people added reviews / acks. I don't personally think this is important enough to spin a v4 for, though the last word would be Bjorn. > --- > > Changes in v3: > - Fixed Author > - Fixed duplicate Signed-off-by Technically this should have been: Changes in v3: - Really really fixed Signed-off-by Changes in v2: - Fixed Author - Fixed duplicate Signed-off-by ...but that's also not really worth spinning for. I think this looks good now. Though unofficial (and not stable git hashes), I've been trying to keep track of some patches during this dead time till -rc1. I've put your two patches here: https://github.com/dianders/kernel-staging/commits/qcom/arm64-staging -Doug
