On 23/07/2022 22:56, Konrad Dybcio wrote: > > > On 23.07.2022 19:46, Krzysztof Kozlowski wrote: >> On 23/07/2022 12:01, Konrad Dybcio wrote: >>> Add device tree bindings for global clock controller for SM6375 SoCs. >>> >>> Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxx> >>> --- >>> Changes since v2: >>> - reference qcom,gcc.yaml >>> >>> .../bindings/clock/qcom,sm6375-gcc.yaml | 48 ++++ >>> include/dt-bindings/clock/qcom,sm6375-gcc.h | 234 ++++++++++++++++++ >>> 2 files changed, 282 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/clock/qcom,sm6375-gcc.yaml >>> create mode 100644 include/dt-bindings/clock/qcom,sm6375-gcc.h >>> >>> diff --git a/Documentation/devicetree/bindings/clock/qcom,sm6375-gcc.yaml b/Documentation/devicetree/bindings/clock/qcom,sm6375-gcc.yaml >>> new file mode 100644 >>> index 000000000000..fb1c36888d18 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/clock/qcom,sm6375-gcc.yaml >>> @@ -0,0 +1,48 @@ >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/clock/qcom,sm6375-gcc.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: Qualcomm Global Clock & Reset Controller Binding for SM6375 >>> + >>> +maintainers: >>> + - Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxx> >>> + >>> +description: | >>> + Qualcomm global clock control module which supports the clocks, resets and >>> + power domains on SM6375 >>> + >>> + See also: >>> + - dt-bindings/clock/qcom,sm6375-gcc.h >>> + >>> +allOf: >>> + - $ref: qcom,gcc.yaml# >>> + >>> +properties: >>> + compatible: >>> + const: qcom,sm6375-gcc >>> + >>> + clocks: >>> + items: >>> + - description: Board XO source >>> + - description: Board XO Active-Only source >>> + - description: Sleep clock source >> >> What happened to clock-names? >> >>> + >> >> I would assume these are required for the clock controller... and they >> were before, so what happened? > I dropped them in v2, as with switching the .c driver to use the > index matching, they are no longer used. OK, but what about clocks as required? Why aren't these now required? Best regards, Krzysztof
