On 7/12/22 15:23, Viswanath Boma wrote: > V4l2 encoder compliance expecting End of sream Event registration support for Encoder. Start sentence from the begging of the line. > > Change-Id: I85f7732a2ec08eba47c0d37181f739e90a7ab63a No Change-Ids > Signed-off-by: Viswanath Boma <quic_vboma@xxxxxxxxxxx> > --- > drivers/media/platform/qcom/venus/venc.c | 16 +++++++++++++++- > 1 file changed, 15 insertions(+), 1 deletion(-) With the comments addressed: Acked-by: Stanimir Varbanov <stanimir.varbanov@xxxxxxxxxx> > > diff --git a/drivers/media/platform/qcom/venus/venc.c b/drivers/media/platform/qcom/venus/venc.c > index b56960d7f6c89..30ddb84c24997 100644 > --- a/drivers/media/platform/qcom/venus/venc.c > +++ b/drivers/media/platform/qcom/venus/venc.c > @@ -507,6 +507,20 @@ static int venc_enum_frameintervals(struct file *file, void *fh, > return 0; > } > > +static int venc_subscribe_event(struct v4l2_fh *fh, > + const struct v4l2_event_subscription *sub) > +{ > + > + switch (sub->type) { > + case V4L2_EVENT_EOS: > + return v4l2_event_subscribe(fh, sub, 2, NULL); > + case V4L2_EVENT_CTRL: > + return v4l2_ctrl_subscribe_event(fh, sub); > + default: > + return -EINVAL; > + } > +} > + > static int > venc_encoder_cmd(struct file *file, void *fh, struct v4l2_encoder_cmd *cmd) > { > @@ -572,7 +586,7 @@ static const struct v4l2_ioctl_ops venc_ioctl_ops = { > .vidioc_g_parm = venc_g_parm, > .vidioc_enum_framesizes = venc_enum_framesizes, > .vidioc_enum_frameintervals = venc_enum_frameintervals, > - .vidioc_subscribe_event = v4l2_ctrl_subscribe_event, > + .vidioc_subscribe_event = venc_subscribe_event, > .vidioc_unsubscribe_event = v4l2_event_unsubscribe, > .vidioc_encoder_cmd = venc_encoder_cmd, > }; -- regards, Stan