Re: [PATCH 1/1] clk/qcom/drivers/sm6350: qcom_cc_really_probe(pdev, &gcc_sm6350_desc, regmap) is assigned an extra semicolon

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 22-07-25 10:16:23, XU pengfei wrote:
> I think this semicolon could be deleted.
>
> Signed-off-by: XU pengfei <xupengfei@xxxxxxxxxxxx>

Thank you for your patch, but there are a few things you should change.

First of, the subject line should be something like:

clk: qcom: gcc-sm6350: Remove unnecessary semicolon

Then, your commit message should say what it does.
Maybe something like:

Remove unnecessary semicolon after qcom_cc_really_probe call.

Also, there is a document that describes everthing about submitting
patches. See Documentation/process/submitting-patches.rst.

> ---
>  drivers/clk/qcom/gcc-sm6350.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/qcom/gcc-sm6350.c b/drivers/clk/qcom/gcc-sm6350.c
> index a4f7fba70393..69412400efa4 100644
> --- a/drivers/clk/qcom/gcc-sm6350.c
> +++ b/drivers/clk/qcom/gcc-sm6350.c
> @@ -2558,7 +2558,7 @@ static int gcc_sm6350_probe(struct platform_device *pdev)
>  	if (ret)
>  		return ret;
>
> -	return qcom_cc_really_probe(pdev, &gcc_sm6350_desc, regmap);;
> +	return qcom_cc_really_probe(pdev, &gcc_sm6350_desc, regmap);
>  }
>
>  static struct platform_driver gcc_sm6350_driver = {
> --
> 2.18.2
>



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux