On 24.7.2022 21.55, Dmitry Baryshkov wrote: > On Sun, 24 Jul 2022 at 20:25, Matti Lehtimäki <matti.lehtimaki@xxxxxxxxx> wrote: >> +/delete-node/ &smem_region; > > Please move this to the /reserved-memory node. having it there would > help understanding that we are just changing the address. I can move this to /reserved-memory node in next version. Other option would be to have a comment here, it seems both ways are used. >> + i2c-muic { >> + compatible = "i2c-gpio"; > > Is there any reason for using i2c-gpio rather than blsp_i2c4? > According to the pinctrl-msm8226, gpio14/15 can be mapped to the blsp. The reason to use i2c-gpio for this was using the other devices with similar node as an example. I tested and having the muic node in blsp_i2c4 worked the same. -Matti