On Samstag, 23. Juli 2022 20:44:08 CEST Krzysztof Kozlowski wrote: > On 23/07/2022 20:17, Luca Weiss wrote: > > On Samstag, 23. Juli 2022 19:36:17 CEST Krzysztof Kozlowski wrote: > >> On 23/07/2022 11:58, Luca Weiss wrote: > >>> See also > >>> https://lore.kernel.org/linux-arm-msm/20191104210943.101393-1-luca@z3ntu > >>> .x > >>> yz/ (never applied for some reason) > >> > >> Mentioned patch is incorrect so should not be applied - it removes at > >> least TMPFS which is not desired. I did not check other removed symbols. > > > > For this example: TMPFS is still enabled after this, it's selected by > > other > > options, like DRM or COMMON_CLK. > > I know, it does not matter. We had this case (with DEBUGFS and probably > others) and the decision was - user visible symbols must no be removed > by savedefconfig. So savedefconfig is "broken" (not doing the correct thing) then or what? Sounds like a topic for kconfig maintainers? > > > Imo not doing this just hides the brokeness as options wouldn't get > > selected anyways when you do "make qcom_defconfig". Savedefconfig > > afterwards just puts reality into the defconfig file. And yes, if some > > option gets lost then some dependency for it probably needs to get > > enabled as well and this should get fixed. > > But dependencies are no being enabled, because expectation is that all > user-visible options are selected by defconfig. > > > Best regards, > Krzysztof
