On Thu, 21 Jul 2022 at 22:55, Bhupesh Sharma <bhupesh.sharma@xxxxxxxxxx> wrote: > > As Bjorn noted in [1], it is useful to describe the optional > 'reg' property for Qualcomm LPG nodes as it is used in > some Qualcomm dts files. I don't think this is correct. LPG block maps to several regions, so using just one of them in reg doesn't look correct. > This fixes the following 'make dtbs_check' error reported for > pm8350c & sc8280xp pwm nodes: > > arch/arm64/boot/dts/qcom/sc7280-herobrine-herobrine-r1.dtb: > pwm@e800: 'reg' does not match any of the regexes: > '^led@[0-9a-f]$', 'pinctrl-[0-9]+' I'd prefer to follow the existing schema and to drop the region from those files. > > [1]. https://lore.kernel.org/linux-arm-msm/Ytg3tIaL5h5b9ewH@xxxxxxxxxxx/ > > Cc: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx> > Cc: robh@xxxxxxxxxx > Cc: pavel@xxxxxx > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@xxxxxxxxxx> > --- > Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml b/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml > index fe336fa16518..f394ab7a757b 100644 > --- a/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml > +++ b/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml > @@ -27,6 +27,9 @@ properties: > - qcom,pmi8994-lpg > - qcom,pmi8998-lpg > > + reg: > + maxItems: 1 > + > "#pwm-cells": > const: 2 > > -- > 2.35.3 > -- With best wishes Dmitry
