On 7/19/22 20:18, Rob Clark wrote: > +void > +drm_gem_lru_move_tail_locked(struct drm_gem_lru *lru, struct drm_gem_object *obj) > +{ > + WARN_ON(!mutex_is_locked(lru->lock)); Nit: What about lockdep_assert_held_once(&lru->lock->base)) ? Otherwise, looks good! I'll use it for the DRM-SHMEM shrinker after completing the work on the dma-buf locks. Reviewed-by: Dmitry Osipenko <dmitry.osipenko@xxxxxxxxxxxxx> -- Best regards, Dmitry