Hi Caleb, On Mon, Jul 18, 2022 at 10:30:50PM +0100, Caleb Connolly wrote: > From: Sumit Semwal <sumit.semwal@xxxxxxxxxx> > > LG SW43408 is 1080x2160, 4-lane MIPI-DSI panel. A few things to improve to this binding. Sam > > Signed-off-by: Vinod Koul <vkoul@xxxxxxxxxx> > Signed-off-by: Sumit Semwal <sumit.semwal@xxxxxxxxxx> > [caleb: convert to yaml] > Signed-off-by: Caleb Connolly <caleb@xxxxxxxxxxxxx> > --- > .../bindings/display/panel/lg,43408.yaml | 41 +++++++++++++++++++ > .../display/panel/panel-simple-dsi.yaml | 2 + > 2 files changed, 43 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/panel/lg,43408.yaml > > diff --git a/Documentation/devicetree/bindings/display/panel/lg,43408.yaml b/Documentation/devicetree/bindings/display/panel/lg,43408.yaml > new file mode 100644 > index 000000000000..0529a3aa2692 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/lg,43408.yaml > @@ -0,0 +1,41 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/panel/panel-lvds.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: LG SW43408 1080x2160 DSI panel > + > +maintainers: > + - Caleb Connolly <caleb@xxxxxxxxxxxxx> > + > +description: | > + This panel is used on the Pixel 3, it is a 60hz OLED panel which > + required DSC (Display Stream Compression) and has rounded corners. > + > +allOf: > + - $ref: panel-common.yaml# > + > +properties: > + compatible: > + items: > + - const: lg,sw43408 > + > + vddi-supply: true > + vpnl-supply: true > + reset-gpios: true > + > + backlight: false > + power-supply: false No need to say anything is false, this is covered by the statement below. Also, the driver uses backlight, so it should be true? > + > +additionalProperties: false > + > +required: > + - compatible > + - data-mapping > + - width-mm > + - height-mm > + - panel-timing > + - port > + > +... > diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml > index 2c00813f5d20..4498078cb1ee 100644 > --- a/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml > +++ b/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml > @@ -45,6 +45,8 @@ properties: > - lg,acx467akm-7 > # LG Corporation 7" WXGA TFT LCD panel > - lg,ld070wx3-sl01 > + # LG Corporation sw43408 1080x2160 OLED > + - lg,sw43408 The panel uses three power-supplies, so it is not a "panel-simple" binding. And we cannot have the same compatible twice, so this must be dropped. Sam
