On 14/07/2022 20:48, Stephan Gerhold wrote:
> On Thu, Jul 14, 2022 at 11:50:30AM +0200, Krzysztof Kozlowski wrote:
>> On 12/07/2022 14:44, Stephan Gerhold wrote:
>>> [...]
>>> +properties:
>>> + compatible:
>>> + oneOf:
>>> + - enum:
>>> + - qcom,msm8916-mss-pil
>>> +
>>> + - const: qcom,q6v5-pil
>>> + description: Deprecated, prefer using qcom,msm8916-mss-pil
>>> + deprecated: true
>>
>> The last compatible does not seem applicable here. Aren't you moving
>> only MSM8916 to new schema?
>>
>
> "qcom,q6v5-pil" is exactly the same as "qcom,msm8916-mss-pil". It's just
> a deprecated quite unfortunately chosen old name for the same thing. :)
>
> See these lines in the driver:
>
> { .compatible = "qcom,q6v5-pil", .data = &msm8916_mss},
> { .compatible = "qcom,msm8916-mss-pil", .data = &msm8916_mss},
Yeah, but previous bindings were not mentioning it alone, so this would
not be a direct conversion.
Best regards,
Krzysztof
