On 29/06/2022 16:03, Bryan O'Donoghue wrote:
At the moment the CPR genpd based code is named after the qcs404 however msm8936, msm8939 and other antecedent processors of the qcs404 can also make use of this data. Rename it to reflect a more generic use. Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx> --- drivers/cpufreq/qcom-cpufreq-nvmem.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/cpufreq/qcom-cpufreq-nvmem.c b/drivers/cpufreq/qcom-cpufreq-nvmem.c index 6dfa86971a757..355c8b99e974a 100644 --- a/drivers/cpufreq/qcom-cpufreq-nvmem.c +++ b/drivers/cpufreq/qcom-cpufreq-nvmem.c @@ -252,10 +252,10 @@ static const struct qcom_cpufreq_match_data match_data_krait = { .get_version = qcom_cpufreq_krait_name_version, };-static const char *qcs404_genpd_names[] = { "cpr", NULL };+static const char *cpr_genpd_names[] = { "cpr", NULL };
As a generic comment, as you are touching this piece of code, code you please move cpr_genpd_names above match_data_kryo? So that all match_data instances can use it.
-static const struct qcom_cpufreq_match_data match_data_qcs404 = {- .genpd_names = qcs404_genpd_names, +static const struct qcom_cpufreq_match_data match_data_cpr_genpd = { + .genpd_names = cpr_genpd_names, };static int qcom_cpufreq_probe(struct platform_device *pdev)@@ -454,7 +454,7 @@ static struct platform_driver qcom_cpufreq_driver = { static const struct of_device_id qcom_cpufreq_match_list[] __initconst = { { .compatible = "qcom,apq8096", .data = &match_data_kryo }, { .compatible = "qcom,msm8996", .data = &match_data_kryo }, - { .compatible = "qcom,qcs404", .data = &match_data_qcs404 }, + { .compatible = "qcom,qcs404", .data = &match_data_cpr_genpd }, { .compatible = "qcom,ipq8064", .data = &match_data_krait }, { .compatible = "qcom,apq8064", .data = &match_data_krait }, { .compatible = "qcom,msm8974", .data = &match_data_krait },
-- With best wishes Dmitry
