Hi, On Mon, Jul 11, 2022 at 2:21 AM Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> wrote: > > Rather than reading the pdata->connector directly, fetch the connector > using drm_atomic_state. This allows us to make pdata->connector optional > (and thus supporting DRM_BRIDGE_ATTACH_NO_CONNECTOR). > > Reviewed-by: Sam Ravnborg <sam@xxxxxxxxxxxx> > Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> > --- > drivers/gpu/drm/bridge/ti-sn65dsi86.c | 22 ++++++++++++++++------ > 1 file changed, 16 insertions(+), 6 deletions(-) Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx> I tested this on a google,lazor-rev5-sku6 (your code correctly found bpc as 6) and a google,coachz-rev2-sku0 (your code correctly found bpc as 8). As an extra safety net, I also double-checked that the generic edp-panel would work. I also hacked the first device to use "edp-panel" as a compatible string, found the panel to be detected, and found bpc was properly found as 6. So from a testing perspective this seems good. Tested-by: Douglas Anderson <dianders@xxxxxxxxxxxx>