Hi Vijaya, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on tty/tty-testing] [also build test WARNING on linus/master v5.19-rc5 next-20220707] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Vijaya-Krishna-Nivarthi/tty-serial-qcom-geni-serial-Fix-get_clk_div_rate-which-otherwise-could-return-a-sub-optimal-clock-rate/20220708-031921 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing config: hexagon-randconfig-r023-20220707 (https://download.01.org/0day-ci/archive/20220708/202207081429.4VXpQCls-lkp@xxxxxxxxx/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 562c3467a6738aa89203f72fc1d1343e5baadf3c) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/fbd8a1a4b7d91ea5caa048e4557ab18b0d08ea86 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Vijaya-Krishna-Nivarthi/tty-serial-qcom-geni-serial-Fix-get_clk_div_rate-which-otherwise-could-return-a-sub-optimal-clock-rate/20220708-031921 git checkout fbd8a1a4b7d91ea5caa048e4557ab18b0d08ea86 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash drivers/tty/serial/ If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot <lkp@xxxxxxxxx> All warnings (new ones prefixed by >>): >> drivers/tty/serial/qcom_geni_serial.c:1007:26: warning: format specifies type 'unsigned long' but the argument has type 'unsigned int' [-Wformat] desired_clk, ser_clk, *clk_div); ^~~~~~~~ include/linux/printk.h:610:38: note: expanded from macro 'pr_debug' no_printk(KERN_DEBUG pr_fmt(fmt), ##__VA_ARGS__) ~~~ ^~~~~~~~~~~ include/linux/printk.h:131:17: note: expanded from macro 'no_printk' printk(fmt, ##__VA_ARGS__); \ ~~~ ^~~~~~~~~~~ include/linux/printk.h:480:60: note: expanded from macro 'printk' #define printk(fmt, ...) printk_index_wrap(_printk, fmt, ##__VA_ARGS__) ~~~ ^~~~~~~~~~~ include/linux/printk.h:452:19: note: expanded from macro 'printk_index_wrap' _p_func(_fmt, ##__VA_ARGS__); \ ~~~~ ^~~~~~~~~~~ 1 warning generated. vim +1007 drivers/tty/serial/qcom_geni_serial.c 983 984 static unsigned long get_clk_div_rate(struct clk *clk, unsigned int baud, 985 unsigned int sampling_rate, unsigned int *clk_div) 986 { 987 unsigned long ser_clk; 988 unsigned long desired_clk; 989 990 desired_clk = baud * sampling_rate; 991 if (!desired_clk) { 992 pr_err("%s: Invalid frequency\n", __func__); 993 return 0; 994 } 995 996 /* 997 * try to find a clock rate within 2% tolerance, then within 998 */ 999 ser_clk = find_clk_rate_in_tol(clk, desired_clk, clk_div, 2); 1000 if (!ser_clk) 1001 ser_clk = find_clk_rate_in_tol(clk, desired_clk, clk_div, 5); 1002 1003 if (!ser_clk) 1004 pr_err("Couldn't find suitable clock rate for %lu\n", desired_clk); 1005 else 1006 pr_debug("desired_clk-%lu, ser_clk-%lu, clk_div-%lu\n", > 1007 desired_clk, ser_clk, *clk_div); 1008 1009 return ser_clk; 1010 } 1011 -- 0-DAY CI Kernel Test Service https://01.org/lkp
