On 06/07/2022 23:47, Douglas Anderson wrote:
> This reverts commit afcbe252e9c19161e4d4c95f33faaf592f1de086.
>
> The commit in question caused my sc7280-herobrine-herobrine-r1 board
> not to boot anymore. This shouldn't be too surprising since the driver
> is relying on the name "cqhci".
Thanks for finding the issue.
>
> The issue seems to be that someone decided to change the names of
> things when the binding moved from .txt to .yaml. We should go back to
> the names that the bindings have historically specified.
>
> For some history, see commit d3392339cae9 ("mmc: cqhci: Update cqhci
> memory ioresource name") and commit d79100c91ae5 ("dt-bindings: mmc:
> sdhci-msm: Add CQE reg map").
>
> Fixes: afcbe252e9c1 ("arm64: dts: qcom: Fix 'reg-names' for sdhci nodes")
> Signed-off-by: Douglas Anderson <dianders@xxxxxxxxxxxx>
> ---
> This is just a straight revert. That presumably means we'll get some
> "make dtbs_check" warnings that were fixed by the commit being
> reverted. I'll leave it to the authors of the original commit to
> adjust the bindings to fix those.
Thanks for the report. I can help here.
Best regards,
Krzysztof
