On Sun, 8 May 2022 12:03:33 +0200, Marijn Suijten wrote: > Both the sdc2-on and sdc2-off pinctrl nodes are used by the > sdhci@4784000 node in sm6125.dtsi. Surprisingly sdc2-off is defined in > sm6125, yet its sdc2-on counterpart is only defined in board-specific DT > for the Sony Seine PDX201 board/device resulting in an "undefined label > &sdc2_state_on" error if sm6125.dtsi were included elsewhere. > This sm6125 base dtsi should not rely on externally defined labels; the > properties referencing it should then also be written externally. > Since the sdc2-on pin configuration is board-independent just like > sdc2-off, move it from seine-pdx201.dts into sm6125.dtsi. > > [...] Applied, thanks! [1/3] arm64: dts: qcom: sm6125: Move sdc2 pinctrl from seine-pdx201 to sm6125 commit: 6990640a93ba4e76dd62ca3ea1082a7354db09d7 [2/3] arm64: dts: qcom: sm6125: Append -state suffix to pinctrl nodes commit: cbfb5668aece448877fa7826cde81c9d06f4a4ac [3/3] arm64: dts: qcom: sm6125: Add DLL/DDR configuration on SDHCI 1/2 commit: e5de51e264e147d4bf882a464fb89501e9c87e14 Best regards, -- Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>