On 06/07/2022 16:54, Dmitry Baryshkov wrote: > To ease merging of bindings and dts files, the constants were replaced In the future I recommend just adding defines in top part of DTSI (under ifdef not defined). Then when time comes, you drop this entire piece of defines which makes it extra readable and easy to review. Nice clean patchset. To review this approach, I would need to check every define if it matches the previous number. Best regards, Krzysztof