On Fri, Sep 26, 2014 at 1:07 AM, Mike Rapoport <mike.rapoport@xxxxxxxxx> wrote:
Cool to see the addition of dt for additional devices. I do however
not think it is correct to put all these things in common...
> diff --git a/arch/arm/boot/dts/qcom-apq8064-board-common.dtsi b/arch/arm/boot/dts/qcom-apq8064-board-common.dtsi
> new file mode 100644
> index 0000000..c92d3e9
> --- /dev/null
> +++ b/arch/arm/boot/dts/qcom-apq8064-board-common.dtsi
> @@ -0,0 +1,57 @@
> +#include "qcom-apq8064-v2.0.dtsi"
> +
> +/ {
> +
> + soc {
> + pinctrl@800000 {
> + i2c1_pins: i2c1 {
> + mux {
> + pins = "gpio20", "gpio21";
> + function = "gsbi1";
> + };
The muxing is common, but you probably want to be able to set drive
strength and bias as well and handle active vs sleep mode and then I'm
not sure if it is common anymore...
> + };
> + };
> +
> + gsbi@12440000 {
> + status = "okay";
> + qcom,mode = <GSBI_PROT_I2C>;
> +
> + i2c@12460000 {
> + status = "okay";
> + clock-frequency = <200000>;
> + pinctrl-0 = <&i2c1_pins>;
> + pinctrl-names = "default";
> +
> + eeprom: eeprom@52 {
> + compatible = "atmel,24c128";
> + reg = <0x52>;
> + pagesize = <32>;
> + };
Not all apq8064 boards have this eeprom.
> + };
> + };
> +
> + gsbi@16600000 {
> + status = "ok";
> + qcom,mode = <GSBI_PROT_I2C_UART>;
> + serial@16640000 {
> + status = "ok";
> + };
> + };
> +
> + amba {
> + /* eMMC */
> + sdcc1: sdcc@12400000 {
> + status = "okay";
> + };
> +
> + /* External micro SD card */
> + sdcc3: sdcc@12180000 {
> + status = "okay";
> + };
> + /* WLAN */
> + sdcc4: sdcc@121c0000 {
> + status = "okay";
> + };
I'm not sure if all boards are using sdcc4 for WiFi.
Regards,
Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
