Re: [PATCH 1/6] dt-bindings: clock: Add schema for MSM8909 GCC

[Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>]

On 04/07/2022 15:29, Stephan Gerhold wrote:
> The Global Clock Controller (GCC) in the MSM8909 SoC provides clocks,
> resets and power domains for the various hardware blocks in the SoC.
> Add a DT schema to describe it, similar to other Qualcomm SoCs.
> 
> Signed-off-by: Stephan Gerhold <stephan.gerhold@xxxxxxxxxxxxxxx>
> ---
>  .../bindings/clock/qcom,gcc-msm8909.yaml      |  56 +++++
>  include/dt-bindings/clock/qcom,gcc-msm8909.h  | 218 ++++++++++++++++++
>  2 files changed, 274 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/clock/qcom,gcc-msm8909.yaml
>  create mode 100644 include/dt-bindings/clock/qcom,gcc-msm8909.h
> 
> diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc-msm8909.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc-msm8909.yaml
> new file mode 100644
> index 000000000000..79b50405864b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/qcom,gcc-msm8909.yaml
> @@ -0,0 +1,56 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/clock/qcom,gcc-msm8909.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm Global Clock & Reset Controller Binding for MSM8909
> +
> +maintainers:
> +  - Stephan Gerhold <stephan@xxxxxxxxxxx>
> +
> +description: |
> +  Qualcomm global clock control module which supports the clocks, resets and
> +  power domains on MSM8909.
> +
> +  See also:
> +  - dt-bindings/clock/qcom,gcc-msm8909.h
> +
> +properties:
> +  compatible:
> +    const: qcom,gcc-msm8909
> +
> +  clocks:
> +    items:
> +      - description: XO source
> +      - description: Sleep clock source
> +      - description: DSI phy instance 0 dsi clock
> +      - description: DSI phy instance 0 byte clock
> +
> +  clock-names:
> +    items:
> +      - const: xo
> +      - const: sleep_clk
> +      - const: dsi0pll
> +      - const: dsi0pllbyte
> +
> +required:
> +  - compatible

Aren't clocks also required? I would assume at least XO is necessary as
input.

> +
> +allOf:
> +  - $ref: qcom,gcc.yaml#
> +
> +unevaluatedProperties: false



Best regards,
Krzysztof