On Thu, Jun 30, 2022 at 08:47:32PM +0200, Krzysztof Kozlowski wrote:
> On 30/06/2022 06:23, Bryan O'Donoghue wrote:
> > diff --git a/Documentation/devicetree/bindings/extcon/qcom,pm8941-misc.yaml b/Documentation/devicetree/bindings/extcon/qcom,pm8941-misc.yaml
> > index 6a9c96f0352ac..1bc412a4ac5e6 100644
> > --- a/Documentation/devicetree/bindings/extcon/qcom,pm8941-misc.yaml
> > +++ b/Documentation/devicetree/bindings/extcon/qcom,pm8941-misc.yaml
> > @@ -27,10 +27,14 @@ properties:
> >
> > interrupt-names:
> > minItems: 1
> > - items:
> > - - const: usb_id
> > - - const: usb_vbus
> > -
> > + anyOf:
> > + - items:
> > + - const: usb_id
> > + - const: usb_vbus
> > + - items:
> > + - const: usb_id
>
> I don't think you can have ID connected and VBUS disconnected, therefore
> is it even possible to have missing VBUS interrupt?
>
The driver was originally made for pm8941, which uses exactly the
usb_id-only configuration (see arch/arm/boot/dts/qcom-pm8941.dtsi):
usb_id: misc@900 {
compatible = "qcom,pm8941-misc";
reg = <0x900>;
interrupts = <0x0 0x9 0 IRQ_TYPE_EDGE_BOTH>;
interrupt-names = "usb_id";
};
The "usb_vbus" interrupt is basically already assigned to the charger
node ("usb-valid" in qcom,pm8941-charger), so I'm not sure if it's
possible to add it to the extcon node as well. The charger driver
provides a separate extcon device with the VBUS state so it's not much
of a problem in practice.
Thanks,
Stephan
