On 30/06/2022 06:35, Bryan O'Donoghue wrote: > msm8916, msm8939, msm8953, msm8994 and qcs404 already declare or should > declare syscon as they have drivers that use syscon inside of the apcs-kpss > block. > > grep apcs arch/arm64/boot/dts/qcom/* | grep syscon > > Add in the additional syscon in the documentation for the above mentioned > parts. Subject should have prefix: dt-bindings: mailbox: qcom,apcs-kpss-global: > > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx> > --- > .../mailbox/qcom,apcs-kpss-global.yaml | 44 ++++++++++--------- > 1 file changed, 24 insertions(+), 20 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml > index 3b5ba7ecc19d9..f342494fd6108 100644 > --- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml > +++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml > @@ -15,26 +15,30 @@ maintainers: > > properties: > compatible: > - enum: > - - qcom,ipq6018-apcs-apps-global > - - qcom,ipq8074-apcs-apps-global > - - qcom,msm8916-apcs-kpss-global > - - qcom,msm8939-apcs-kpss-global > - - qcom,msm8953-apcs-kpss-global > - - qcom,msm8976-apcs-kpss-global > - - qcom,msm8994-apcs-kpss-global > - - qcom,msm8996-apcs-hmss-global > - - qcom,msm8998-apcs-hmss-global > - - qcom,qcm2290-apcs-hmss-global > - - qcom,qcs404-apcs-apps-global > - - qcom,sc7180-apss-shared > - - qcom,sc8180x-apss-shared > - - qcom,sdm660-apcs-hmss-global > - - qcom,sdm845-apss-shared > - - qcom,sm6125-apcs-hmss-global > - - qcom,sm6115-apcs-hmss-global > - - qcom,sm8150-apss-shared > - > + oneOf: > + - items: > + - enum: > + - qcom,ipq6018-apcs-apps-global > + - qcom,ipq8074-apcs-apps-global > + - qcom,msm8976-apcs-kpss-global > + - qcom,msm8996-apcs-hmss-global > + - qcom,msm8998-apcs-hmss-global > + - qcom,qcm2290-apcs-hmss-global > + - qcom,sc7180-apss-shared > + - qcom,sc8180x-apss-shared > + - qcom,sdm660-apcs-hmss-global > + - qcom,sdm845-apss-shared > + - qcom,sm6125-apcs-hmss-global > + - qcom,sm6115-apcs-hmss-global > + - qcom,sm8150-apss-shared These are not items, but one item, so enum directly under oneOf. > + - items: > + - enum: > + - qcom,msm8916-apcs-kpss-global > + - qcom,msm8939-apcs-kpss-global > + - qcom,msm8953-apcs-kpss-global > + - qcom,msm8994-apcs-kpss-global > + - qcom,qcs404-apcs-apps-global > + - const: syscon > reg: > maxItems: 1 > Best regards, Krzysztof
