On 30 June 2022 15:08:44 GMT+03:00, Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx> wrote:
>Add in missing clock and clock-names declarations to the 28nm DSI PHY.
>When converting from .txt to .yaml we missed these.
>
>Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings")
>Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>
>---
> .../bindings/display/msm/dsi-phy-28nm.yaml | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
>
>diff --git a/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml b/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml
>index 3d8540a06fe22..9ecd513d93661 100644
>--- a/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml
>+++ b/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml
>@@ -19,6 +19,21 @@ properties:
> - qcom,dsi-phy-28nm-lp
> - qcom,dsi-phy-28nm-8960
>
>+ clocks:
>+ minItems: 1
>+ maxItems: 2
>+
>+ clock-names:
>+ items:
>+ - const: iface
>+ description: AHB clock
>+ - const: iface_clk
>+ description: AHB clock
>+ - const: ref
>+ description: Block reference clock
>+ minItems: 1
>+ maxItems: 2
This looks incorrect. You have 3 items, but maxItems in 2
Also I'd put description to the clocks node. Clock-names are self-descriptive enough.
>+
> reg:
> items:
> - description: dsi pll register set
>@@ -36,6 +51,8 @@ properties:
>
> required:
> - compatible
>+ - clocks
>+ - clock-names
> - reg
> - reg-names
> - vddio-supply
--
With best wishes
Dmitry
