On 28/06/2022 16:55, Stephan Gerhold wrote: > Document the "qcom,msm8909-tlmm" compatible for the TLMM/pin control > block in the MSM8909 SoC, together with the allowed GPIOs and functions. > > Signed-off-by: Stephan Gerhold <stephan.gerhold@xxxxxxxxxxxxxxx> > --- > .../bindings/pinctrl/qcom,msm8909-tlmm.yaml | 152 ++++++++++++++++++ > 1 file changed, 152 insertions(+) > create mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,msm8909-tlmm.yaml > > diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,msm8909-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,msm8909-tlmm.yaml > new file mode 100644 > index 000000000000..e03530091478 > --- /dev/null > +++ b/Documentation/devicetree/bindings/pinctrl/qcom,msm8909-tlmm.yaml > @@ -0,0 +1,152 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/pinctrl/qcom,msm8909-tlmm.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm Technologies, Inc. MSM8909 TLMM block > + > +maintainers: > + - Stephan Gerhold <stephan@xxxxxxxxxxx> > + > +description: | > + This binding describes the Top Level Mode Multiplexer (TLMM) block found > + in the MSM8909 platform. > + > +allOf: > + - $ref: /schemas/pinctrl/qcom,tlmm-common.yaml# > + > +properties: > + compatible: > + const: qcom,msm8909-tlmm > + > + reg: > + maxItems: 1 > + > + interrupts: true > + interrupt-controller: true > + '#interrupt-cells': true > + gpio-controller: true > + gpio-reserved-ranges: true > + '#gpio-cells': true > + gpio-ranges: true > + wakeup-parent: true > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +patternProperties: > + '-state$': > + oneOf: > + - $ref: "#/$defs/qcom-msm8909-tlmm-state" No quotes here and other places, should be needed. I know you copied from other bindings, but at least let's try new files to be proper. > + - patternProperties: > + ".*": > + $ref: "#/$defs/qcom-msm8909-tlmm-state" > + > +$defs: > + qcom-msm8909-tlmm-state: > + type: object > + description: > + Pinctrl node's client devices use subnodes for desired pin configuration. > + Client device subnodes use below standard properties. > + $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state" Overall looks ok, to me, so with quote changes: Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> Best regards, Krzysztof
