Hi, On Fri, Jun 24, 2022 at 7:28 PM Joseph S. Barrera III <joebar@xxxxxxxxxxxx> wrote: > > diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi > index e55dbaa6dc12..69cd4b3b911b 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi > @@ -11,6 +11,12 @@ > #include <dt-bindings/regulator/qcom,rpmh-regulator.h> > #include <dt-bindings/sound/sc7180-lpass.h> > > +#ifdef __SC7180_TROGDOR_DTSI__ > +#error "Duplicate include" > +#else > +#define __SC7180_TROGDOR_DTSI__ > +#endif > + I'm not convinced about the need for this. That being said: * If you want to try to do something like this, it should be in a separate patch, probably at the end of the series. Then if people all love it then it can be applied and if people don't like it then the series can simply be applied without it. * IMO if you wanted to pick one file to put this in it'd be sc7180.dtsi, not sc7180-trogdor.dtsi. -Doug
