Quoting Dmitry Baryshkov (2022-06-20 08:39:56)
> diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c b/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c
> index a2526068232b..0f31d3255897 100644
> --- a/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c
> +++ b/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c
> @@ -1167,6 +1167,54 @@ static int qcom_qmp_phy_ufs_clk_init(struct device *dev, const struct qmp_phy_cf
> return devm_clk_bulk_get(dev, num, qmp->clks);
> }
>
> +static void phy_clk_release_provider(void *res)
> +{
> + of_clk_del_provider(res);
> +}
> +
> +#define UFS_SYMBOL_CLOCKS 3
> +
> +static int phy_symbols_clk_register(struct qcom_qmp *qmp, struct device_node *np)
> +{
> + struct clk_hw_onecell_data *clk_data;
> + struct clk_hw *hw;
> + int ret;
> +
> + clk_data = devm_kzalloc(qmp->dev, struct_size(clk_data, hws, UFS_SYMBOL_CLOCKS), GFP_KERNEL);
> + clk_data->num = UFS_SYMBOL_CLOCKS;
> +
> + hw = devm_clk_hw_register_fixed_rate(qmp->dev, "ufs_rx_symbol_0_clk_src",
> + NULL, 0, 0);
> + if (IS_ERR(hw))
> + return PTR_ERR(hw);
> +
> + clk_data->hws[0] = hw;
> +
> + hw = devm_clk_hw_register_fixed_rate(qmp->dev, "ufs_rx_symbol_1_clk_src",
> + NULL, 0, 0);
> + if (IS_ERR(hw))
> + return PTR_ERR(hw);
> +
> + clk_data->hws[1] = hw;
> +
> + hw = devm_clk_hw_register_fixed_rate(qmp->dev, "ufs_tx_symbol_0_clk_src",
> + NULL, 0, 0);
This line should be aligned with the opening parenthesis. Same for the
above other two.
> + if (IS_ERR(hw))
> + return PTR_ERR(hw);
> +
> + clk_data->hws[2] = hw;
> +
> + ret = of_clk_add_hw_provider(np, of_clk_hw_onecell_get, clk_data);
> + if (ret)
> + return ret;
> +
> + /*
This is tabbed weird. It doesn't align with the if above.
> + * Roll a devm action because the clock provider is the child node, but
> + * the child node is not actually a device.
> + */
> + return devm_add_action_or_reset(qmp->dev, phy_clk_release_provider, np);
> +}
> +
> static const struct phy_ops qcom_qmp_ufs_ops = {
> .power_on = qcom_qmp_phy_ufs_enable,
> .power_off = qcom_qmp_phy_ufs_disable,
