On 23/06/2022 15:26, Krzysztof Kozlowski wrote: > On 23/06/2022 11:46, Stephan Gerhold wrote: > >> static const struct rpm_regulator_data rpm_pm8916_regulators[] = { >> { "s1", QCOM_SMD_RPM_SMPA, 1, &pm8916_buck_lvo_smps, "vdd_s1" }, >> { "s2", QCOM_SMD_RPM_SMPA, 2, &pm8916_buck_lvo_smps, "vdd_s2" }, >> @@ -1222,6 +1245,7 @@ static const struct rpm_regulator_data rpm_pm2250_regulators[] = { >> static const struct of_device_id rpm_of_match[] = { >> { .compatible = "qcom,rpm-mp5496-regulators", .data = &rpm_mp5496_regulators }, >> { .compatible = "qcom,rpm-pm8841-regulators", .data = &rpm_pm8841_regulators }, >> + { .compatible = "qcom,rpm-pm8909-regulators", .data = &rpm_pm8909_regulators }, >> { .compatible = "qcom,rpm-pm8916-regulators", .data = &rpm_pm8916_regulators }, >> { .compatible = "qcom,rpm-pm8226-regulators", .data = &rpm_pm8226_regulators }, >> { .compatible = "qcom,rpm-pm8941-regulators", .data = &rpm_pm8941_regulators }, > > Isn't this a new compatible? Looks like, so it needs bindings. Ah, I see the patch now. Best regards, Krzysztof