Re: [PATCH 39/49] gpio: sl28cpld: replace irqchip mask_invert with unmask_base

To: Aidan MacDonald <aidanmacdonald.0x0@xxxxxxxxx>
Subject: Re: [PATCH 39/49] gpio: sl28cpld: replace irqchip mask_invert with unmask_base
From: Michael Walle <michael@xxxxxxxx>
Date: Thu, 23 Jun 2022 08:33:53 +0200
Cc: broonie@xxxxxxxxxx, agross@xxxxxxxxxx, bjorn.andersson@xxxxxxxxxx, srinivas.kandagatla@xxxxxxxxxx, bgoswami@xxxxxxxxxxxxxx, gregkh@xxxxxxxxxxxxxxxxxxx, rafael@xxxxxxxxxx, cw00.choi@xxxxxxxxxxx, krzysztof.kozlowski@xxxxxxxxxx, b.zolnierkie@xxxxxxxxxxx, myungjoo.ham@xxxxxxxxxxx, linus.walleij@xxxxxxxxxx, brgl@xxxxxxxx, tglx@xxxxxxxxxxxxx, maz@xxxxxxxxxx, lee.jones@xxxxxxxxxx, mani@xxxxxxxxxx, cristian.ciocaltea@xxxxxxxxx, wens@xxxxxxxx, tharvey@xxxxxxxxxxxxx, rjones@xxxxxxxxxxxxx, mazziesaccount@xxxxxxxxx, orsonzhai@xxxxxxxxx, baolin.wang7@xxxxxxxxx, zhang.lyra@xxxxxxxxx, jernej.skrabec@xxxxxxxxx, samuel@xxxxxxxxxxxx, lgirdwood@xxxxxxxxx, perex@xxxxxxxx, tiwai@xxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-gpio@xxxxxxxxxxxxxxx, linux-actions@xxxxxxxxxxxxxxxxxxx, linux-arm-msm@xxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-sunxi@xxxxxxxxxxxxxxx, alsa-devel@xxxxxxxxxxxxxxxx
In-reply-to: <20220620200644.1961936-40-aidanmacdonald.0x0@gmail.com>
References: <20220620200644.1961936-1-aidanmacdonald.0x0@gmail.com> <20220620200644.1961936-40-aidanmacdonald.0x0@gmail.com>
User-agent: Roundcube Webmail/1.4.13

Am 2022-06-20 22:06, schrieb Aidan MacDonald:

An inverted mask register can be described more directly
as an unmask register.

Signed-off-by: Aidan MacDonald <aidanmacdonald.0x0@xxxxxxxxx>


Reviewed-by: Michael Walle <michael@xxxxxxxx>

References:
- [PATCH 00/49] regmap-irq cleanups and refactoring
  - From: Aidan MacDonald
- [PATCH 39/49] gpio: sl28cpld: replace irqchip mask_invert with unmask_base
  - From: Aidan MacDonald