Thanks Chris. Agreed with all your suggestion, next revision will address your comments. -----Original Message----- From: linux-scsi-owner@xxxxxxxxxxxxxxx [mailto:linux-scsi-owner@xxxxxxxxxxxxxxx] On Behalf Of Dolev Raviv Sent: Tuesday, September 23, 2014 4:49 AM To: Christoph Hellwig Cc: Dolev Raviv; james.bottomley@xxxxxxxxxxxxxxxxxxxxx; hch@xxxxxxxxxxxxx; linux-scsi@xxxxxxxxxxxxxxx; linux-scsi-owner@xxxxxxxxxxxxxxx; linux-arm-msm@xxxxxxxxxxxxxxx; santoshsy@xxxxxxxxx; Subhash Jadavani Subject: Re: [PATCH V4 09/17] scsi: ufs: manually add well known logical units > None of the REPORT LUNS language makes sense as we're not using it. > > Can you respon the patch with a better description, and a little > comment in the code on why you're adding these wluns. ok. > > Also can I assume none of the later patches relies on their existance? In UFS power management commands such as SSU, are sent to "device w- lun". Leaving it out should only affect the ability to suspend the device. Other patches are not directly affected by it. > If you do you need to check the error return from scsi_add_device, if > not said comment should mention why it's fine to not actually find any > of these. > Will discus it further with Subhash. > Also if you do use one of them from kernel space later it might make > more sense to use __scsi_add_device and store a pointer to the > scsi_device instead of looking it up later. > I'll review all you suggestions with Subhash. -- QUALCOMM ISRAEL, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
