Hi, On Fri, Jun 17, 2022 at 11:12 AM Joseph S. Barrera III <joebar@xxxxxxxxxxxx> wrote: > > From: Stephen Boyd <swboyd@xxxxxxxxxxxx> > > Trogdor devices that have a detachable keyboard still have a > non-detachable keyboard input device present because we include the > cros-ec-keyboard.dtsi snippet in the top-level sc7180-trogdor.dtsi file > that every variant board includes. We do this because the > keyboard-controller node also provides some buttons like the power > button and volume buttons. Unfortunately, this means we register a > keyboard input device that doesn't do anything on boards with a > detachable keyboard. > > Change the node's compatible on detachables to the newly introduced > "google,cros-ec-keyb-switches" compatible to indicate that there are > only switches and no keyboard to register. Similarly, move the keyboard > include that defines the keyboard-controller node out of > sc7180-trogdor.dtsi to boards that actually have a keyboard so that the > matrix properties are not defined on boards with the switches > compatible. Future boards can either use the include approach or the > node definition approach to describe a keyboard with possible switches > or just some switches. > > Cc: Benson Leung <bleung@xxxxxxxxxxxx> > Cc: Guenter Roeck <groeck@xxxxxxxxxxxx> > Cc: Douglas Anderson <dianders@xxxxxxxxxxxx> > Cc: Hsin-Yi Wang <hsinyi@xxxxxxxxxxxx> > Cc: "Joseph S. Barrera III" <joebar@xxxxxxxxxxxx> > Signed-off-by: Stephen Boyd <swboyd@xxxxxxxxxxxx> > (am from https://lore.kernel.org/r/20220518172525.3319993-1-swboyd@xxxxxxxxxxxx) > > evtest shows no more cros_ec device > > Cq-Depend: chromium:3609017 > Tested-by: Stephen Boyd <swboyd@xxxxxxxxxxxx> > Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx> > Signed-off-by: Joseph S. Barrera III <joebar@xxxxxxxxxxxx> It's OK to re-post Stephen's patch with your series, but: 1. The subject shouldn't have FROMLIST. That's just for patches picked back to a Chromium OS kernel. 2. You shouldn't have "(am from...)". Again, just for patches picked back to a Chromium OS kernel. 3. No Cq-Depend. That's something for patches picked back to a Chromium OS kernel. 4. You should remove tags that were added by the Chromium review system, like Stephen's "Tested-by" and my "Reviewed-by". Another alternative is to not post Stephen's patch but add a note that your patch should be applied atop his, then point to his. AKA: https://lore.kernel.org/r/20220518172525.3319993-1-swboyd@xxxxxxxxxxxx -Doug
