On 03/06/2022 22:13, Stefan Hansson wrote: > From: Anton Bambura <jenneron@xxxxxxxxxxxxxx> > > Adds initial support for the LG G7 (judyln) and > LG V35 (judyp) phones. > > Currently supported features: > > - Display via simplefb (panel driver is WIP) > - Keys > - Micro SD card > - Modem (not tested much, but initialises) > - UFS (crashes during intensive workloads, may need quirks) > - USB in peripheral mode > > Changes since v1: > > - Enabled GPU > - Changed some node names > - Moved framebuffer node from common dtsi > > I did not change the regulator node names as adding -regulator > everywhere broke USB networking, and as such I reverted it to what > OnePlus 6's common dtsi is doing given that it's well-tested. I do not > have time to debug this further at the moment since I won't have access > to the phone for about 3 months, so I hope this is okay. If not, I'll > have to look into it at a later point. > > Signed-off-by: Anton Bambura <jenneron@xxxxxxxxxxxxxx> > Signed-off-by: Stefan Hansson <newbie13xd@xxxxxxxxx> > Tested-by: Gregari Ivanov <llamashere@xxxxxxxxx> > --- > arch/arm64/boot/dts/qcom/Makefile | 2 + > .../arm64/boot/dts/qcom/sdm845-lg-common.dtsi | 614 ++++++++++++++++++ > arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts | 68 ++ > arch/arm64/boot/dts/qcom/sdm845-lg-judyp.dts | 44 ++ > 4 files changed, 728 insertions(+) > create mode 100644 arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi > create mode 100644 arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts > create mode 100644 arch/arm64/boot/dts/qcom/sdm845-lg-judyp.dts > > diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile > index f9e6343acd03..2f31e62f550c 100644 > --- a/arch/arm64/boot/dts/qcom/Makefile > +++ b/arch/arm64/boot/dts/qcom/Makefile > @@ -99,6 +99,8 @@ dtb-$(CONFIG_ARCH_QCOM) += sdm845-cheza-r1.dtb > dtb-$(CONFIG_ARCH_QCOM) += sdm845-cheza-r2.dtb > dtb-$(CONFIG_ARCH_QCOM) += sdm845-cheza-r3.dtb > dtb-$(CONFIG_ARCH_QCOM) += sdm845-db845c.dtb > +dtb-$(CONFIG_ARCH_QCOM) += sdm845-lg-judyln.dtb > +dtb-$(CONFIG_ARCH_QCOM) += sdm845-lg-judyp.dtb > dtb-$(CONFIG_ARCH_QCOM) += sdm845-mtp.dtb > dtb-$(CONFIG_ARCH_QCOM) += sdm845-oneplus-enchilada.dtb > dtb-$(CONFIG_ARCH_QCOM) += sdm845-oneplus-fajita.dtb > diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi > new file mode 100644 > index 000000000000..e882554b3da8 > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi > @@ -0,0 +1,614 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * SDM845 LG G7 / V35 (judyln / judyp) common device tree > + * > + * Copyright (c) 2022, The Linux Foundation. All rights reserved. > + */ > + > +#include <dt-bindings/gpio/gpio.h> > +#include <dt-bindings/pinctrl/qcom,pmic-gpio.h> > +#include <dt-bindings/regulator/qcom,rpmh-regulator.h> > + > +#include "sdm845.dtsi" > +#include "pm8998.dtsi" > +#include "pmi8998.dtsi" > + > +/delete-node/ &adsp_mem; > +/delete-node/ &cdsp_mem; > +/delete-node/ &gpu_mem; > +/delete-node/ &ipa_fw_mem; > +/delete-node/ &mba_region; > +/delete-node/ &mpss_region; > +/delete-node/ &qseecom_mem; > +/delete-node/ &rmtfs_mem; > +/delete-node/ &slpi_mem; > +/delete-node/ &spss_mem; > +/delete-node/ &venus_mem; > +/delete-node/ &wlan_msa_mem; > + > +/ { > + chosen { > + #address-cells = <2>; > + #size-cells = <2>; > + ranges; > + }; > + > + reserved-memory { > + #address-cells = <2>; > + #size-cells = <2>; > + ranges; > + > + qseecom_mem: memory@b2000000 { > + reg = <0 0xb2000000 0 0x1800000>; > + no-map; > + }; > + > + gpu_mem: memory@8c415000 { > + reg = <0 0x8c415000 0 0x2000>; > + no-map; > + }; > + > + ipa_fw_mem: memory@8c400000 { > + reg = <0 0x8c400000 0 0x10000>; > + no-map; > + }; > + > + adsp_mem: memory@8c500000 { > + reg = <0 0x8c500000 0 0x1e00000>; > + no-map; > + }; > + > + wlan_msa_mem: memory@8e300000 { > + reg = <0 0x8e300000 0 0x100000>; > + no-map; > + }; > + > + mpss_region: memory@8e400000 { > + reg = <0 0x8e400000 0 0x8900000>; > + no-map; > + }; > + > + venus_mem: memory@96d00000 { > + reg = <0 0x96d00000 0 0x500000>; > + no-map; > + }; > + > + cdsp_mem: memory@97200000 { > + reg = <0 0x97200000 0 0x800000>; > + no-map; > + }; > + > + mba_region: memory@97a00000 { > + reg = <0 0x97a00000 0 0x200000>; > + no-map; > + }; > + > + slpi_mem: memory@97c00000 { > + reg = <0 0x97c00000 0 0x1400000>; > + no-map; > + }; > + > + spss_mem: memory@99000000 { > + reg = <0 0x99000000 0 0x100000>; > + no-map; > + }; > + > + /* Framebuffer region */ > + memory@9d400000 { > + reg = <0x0 0x9d400000 0x0 0x2400000>; > + no-map; > + }; > + > + /* rmtfs lower guard */ > + memory@f0800000 { > + reg = <0 0xf0800000 0 0x1000>; > + no-map; > + }; > + > + rmtfs_mem: memory@f0801000 { > + compatible = "qcom,rmtfs-mem"; > + reg = <0 0xf0801000 0 0x200000>; > + no-map; > + > + qcom,client-id = <1>; > + qcom,vmid = <15>; > + }; > + > + /* rmtfs upper guard */ > + memory@f0a01000 { > + reg = <0 0xf0a01000 0 0x1000>; > + no-map; > + }; > + }; > + > + gpio-keys { > + compatible = "gpio-keys"; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&vol_up_pin_a>; > + > + label = "GPIO Buttons"; > + > + key-vol-up { > + label = "Volume up"; > + linux,code = <KEY_VOLUMEUP>; > + gpios = <&pm8998_gpio 6 GPIO_ACTIVE_LOW>; > + }; > + }; > + > + vph_pwr: vph-pwr-regulator { > + compatible = "regulator-fixed"; > + regulator-name = "vph_pwr"; > + regulator-min-microvolt = <3700000>; > + regulator-max-microvolt = <3700000>; > + }; > + > + /* > + * Apparently RPMh does not provide support for PM8998 S4 because it > + * is always-on; model it as a fixed regulator. > + */ > + vreg_s4a_1p8: pm8998-smps4 { My previous comment was ignored here. Is there something not clear? Best regards, Krzysztof