On Tue, Jun 07, 2022 at 09:05:16AM +0200, Ansuel Smith wrote:
> On Tue, Jun 07, 2022 at 02:45:22PM +0530, Manivannan Sadhasivam wrote:
> > On Thu, May 19, 2022 at 09:01:12PM +0200, Ansuel Smith wrote:
> > > Document new qcom,boot-pages binding used to apply special
> > > read/write configuration to boot pages.
> > >
> > > QCOM apply a special configuration where spare data is not protected
> > > by ECC for some special pages (used for boot partition). Add
> > > Documentation on how to declare these special pages.
> > >
> > > Signed-off-by: Ansuel Smith <ansuelsmth@xxxxxxxxx>
> > > ---
> > > .../devicetree/bindings/mtd/qcom,nandc.yaml | 26 +++++++++++++++++++
> > > 1 file changed, 26 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/mtd/qcom,nandc.yaml b/Documentation/devicetree/bindings/mtd/qcom,nandc.yaml
> > > index 84ad7ff30121..a59ae9525f4e 100644
> > > --- a/Documentation/devicetree/bindings/mtd/qcom,nandc.yaml
> > > +++ b/Documentation/devicetree/bindings/mtd/qcom,nandc.yaml
> > > @@ -102,6 +102,30 @@ allOf:
> > > - const: rx
> > > - const: cmd
> > >
> > > + - if:
> > > + properties:
> > > + compatible:
> > > + contains:
> > > + enum:
> > > + - qcom,ipq806x-nand
> > > +
> > > + then:
> > > + properties:
> > > + qcom,boot-pages:
> >
> > Eventhough the page layout is what making the difference, here the boot
> > partition offset and size are getting specified. So how about, changing it
> > to "qcom,boot-partitions"?
> >
> > Thanks,
> > Mani
> >
>
> Yep, you are correct and the naming is confusing. Will do the change.
> Did you check the code if you notice something to improve / an idea of a
> better implementation or better naming?
> Just to skip sending multiple revision with small changes.
>
Yep, I do have some comments. Will share them.
Thanks,
Mani
> > > + $ref: /schemas/types.yaml#/definitions/uint32-matrix
> > > + items:
> > > + items:
> > > + - description: offset
> > > + - description: size
> > > + description:
> > > + Some special page used by boot partition have spare data
> > > + not protected by ECC. Use this to declare these special page
> > > + by defining first the offset and then the size.
> > > +
> > > + It's in the form of <offset1 size1 offset2 size2 offset3 ...>
> > > +
> > > + Refer to the ipq8064 example on how to use this special binding.
> > > +
> > > required:
> > > - compatible
> > > - reg
> > > @@ -135,6 +159,8 @@ examples:
> > > nand-ecc-strength = <4>;
> > > nand-bus-width = <8>;
> > >
> > > + qcom,boot-pages = <0x0 0x58a0000>;
> > > +
> > > partitions {
> > > compatible = "fixed-partitions";
> > > #address-cells = <1>;
> > > --
> > > 2.34.1
> > >
> >
> > --
> > மணிவண்ணன் சதாசிவம்
>
> --
> Ansuel
--
மணிவண்ணன் சதாசிவம்
