On 07/06/2022 01:05, Teguh Sobirin wrote: > Add documentation for "innolux,td4328" panel. > > Signed-off-by: Teguh Sobirin <teguh@xxxxxxxx> > --- > .../display/panel/innolux,td4328.yaml | 83 +++++++++++++++++++ > 1 file changed, 83 insertions(+) > create mode 100755 Documentation/devicetree/bindings/display/panel/innolux,td4328.yaml > > diff --git a/Documentation/devicetree/bindings/display/panel/innolux,td4328.yaml b/Documentation/devicetree/bindings/display/panel/innolux,td4328.yaml > new file mode 100755 > index 000000000000..d4773ade0f13 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/innolux,td4328.yaml > @@ -0,0 +1,83 @@ > +# SPDX-License-Identifier: GPL-2.0 Dual License please (like checkpatch asks). > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/panel/innolux,td4328.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Synaptics TD4328 based DSI display Panels > + > +maintainers: > + - Teguh Sobirin <teguh@xxxxxxxx> > + > +description: | > + The TD4328 IC from Synaptics is a DSI Panel IC used to drive DSI panels. > + > +allOf: > + - $ref: panel-common.yaml# > + > +properties: > + compatible: > + const: innolux,td4328 Innolux or Synaptics? > + description: This indicates the panel manufacturer of the panel that is > + in turn using the TD4328 panel driver. What does the "panel driver" mean here? > + > + reset-gpios: > + maxItems: 1 > + description: phandle of gpio for reset line - This should be 8mA, gpio > + can be configured using mux, pinctrl, pinctrl-names (active high) s/phandle of gpio// Everywhere. > + > + vddio-supply: > + description: phandle of the regulator that provides the supply voltage > + Power IC supply s/phandle of the regulator// Everywhere. This should be simply: "Power IC supply" > + > + vddpos-supply: > + description: phandle of the positive boost supply regulator "Positive boost supply" > + > + vddneg-supply: > + description: phandle of the negative boost supply regulator "Negative boost supply" > + > + rotation: > + description: Display rotation in degrees counter clockwise (0,90,180,270) No need for description, just true > + > + reg: true maxItems > + port: true > + > +required: > + - compatible > + - reg > + - vddio-supply > + - vddpos-supply > + - vddneg-supply > + - reset-gpios > + - rotation > + - port > + > +unevaluatedProperties: false > + > +examples: > + - |+ Just " - |" > + #include <dt-bindings/gpio/gpio.h> > + > + dsi0 { dsi > + #address-cells = <1>; > + #size-cells = <0>; > + > + panel@0 { > + compatible = "innolux,td4328"; > + reg = <0>; > + vddio-supply = <&vreg_l14a_1p88>; > + vddpos-supply = <&lab>; > + vddneg-supply = <&ibb>; > + > + reset-gpios = <&tlmm 6 GPIO_ACTIVE_HIGH>; > + rotation = <90>; > + > + port { > + panel0_in: endpoint { > + remote-endpoint = <&dsi0_out>; > + }; > + }; > + }; > + }; > + > +... Best regards, Krzysztof