On 03/06/2022 11:47, Stefan Hansson wrote:
>>> + gpio-keys {
>>> + compatible = "gpio-keys";
>>> +
>>> + pinctrl-names = "default";
>>> + pinctrl-0 = <&vol_up_pin_a>;
>>> +
>>> + label = "GPIO Buttons";
>>
>> Is "label" really a property of gpio-keys node?
>>
>
> I tested these dts:es with dtbs_check and I do not see any errors
> regarding labels. If you prefer me to delete this I can do that. I
> understand it is rather weird to have this here if it's not in the
> schema. I am rather new to writing device trees, so I think you are
> better off making the call here.
Thanks for reporting. Indeed current DT schema won't detect this. Anyway
it seems gpio-keys driver already uses it and since it appeared in DTS,
maybe better to document it. I'll work on this, so feel free to keep the
property.
Best regards,
Krzysztof
