Re: [PATCH v2 5/7] drm/msm/dpu: change catalog->dma_cfg to be a const pointer

[Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx>]

On 6/2/2022 6:30 AM, Dmitry Baryshkov wrote:
> Change dpu_mdss_cfg::dma_cfg to be a const pointer rather than embedding
> the dpu_reg_dma_cfg struct into the struct dpu_mdss_cfg.
>
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
Reviewed-by: Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx>
> ---
>   drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 12 ++++++------
>   drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h |  2 +-
>   2 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
> index a7040ca5da72..5470b8b14b0a 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
> @@ -1780,7 +1780,7 @@ static void sdm845_cfg_init(struct dpu_mdss_cfg *dpu_cfg)
>   		.vbif_count = ARRAY_SIZE(sdm845_vbif),
>   		.vbif = sdm845_vbif,
>   		.reg_dma_count = 1,
> -		.dma_cfg = sdm845_regdma,
> +		.dma_cfg = &sdm845_regdma,
>   		.perf = &sdm845_perf_data,
>   		.mdss_irqs = IRQ_SDM845_MASK,
>   	};
> @@ -1811,7 +1811,7 @@ static void sc7180_cfg_init(struct dpu_mdss_cfg *dpu_cfg)
>   		.vbif_count = ARRAY_SIZE(sdm845_vbif),
>   		.vbif = sdm845_vbif,
>   		.reg_dma_count = 1,
> -		.dma_cfg = sdm845_regdma,
> +		.dma_cfg = &sdm845_regdma,
>   		.perf = &sc7180_perf_data,
>   		.mdss_irqs = IRQ_SC7180_MASK,
>   	};
> @@ -1844,7 +1844,7 @@ static void sm8150_cfg_init(struct dpu_mdss_cfg *dpu_cfg)
>   		.vbif_count = ARRAY_SIZE(sdm845_vbif),
>   		.vbif = sdm845_vbif,
>   		.reg_dma_count = 1,
> -		.dma_cfg = sm8150_regdma,
> +		.dma_cfg = &sm8150_regdma,
>   		.perf = &sm8150_perf_data,
>   		.mdss_irqs = IRQ_SDM845_MASK,
>   	};
> @@ -1875,7 +1875,7 @@ static void sc8180x_cfg_init(struct dpu_mdss_cfg *dpu_cfg)
>   		.vbif_count = ARRAY_SIZE(sdm845_vbif),
>   		.vbif = sdm845_vbif,
>   		.reg_dma_count = 1,
> -		.dma_cfg = sm8150_regdma,
> +		.dma_cfg = &sm8150_regdma,
>   		.perf = &sc8180x_perf_data,
>   		.mdss_irqs = IRQ_SC8180X_MASK,
>   	};
> @@ -1910,7 +1910,7 @@ static void sm8250_cfg_init(struct dpu_mdss_cfg *dpu_cfg)
>   		.wb_count = ARRAY_SIZE(sm8250_wb),
>   		.wb = sm8250_wb,
>   		.reg_dma_count = 1,
> -		.dma_cfg = sm8250_regdma,
> +		.dma_cfg = &sm8250_regdma,
>   		.perf = &sm8250_perf_data,
>   		.mdss_irqs = IRQ_SM8250_MASK,
>   	};
> @@ -1965,7 +1965,7 @@ static void qcm2290_cfg_init(struct dpu_mdss_cfg *dpu_cfg)
>   		.vbif_count = ARRAY_SIZE(sdm845_vbif),
>   		.vbif = sdm845_vbif,
>   		.reg_dma_count = 1,
> -		.dma_cfg = sdm845_regdma,
> +		.dma_cfg = &sdm845_regdma,
>   		.perf = &qcm2290_perf_data,
>   		.mdss_irqs = IRQ_SC7180_MASK,
>   	};
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h
> index 64ed96b2fa3d..60b403ac9f0f 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h
> @@ -859,7 +859,7 @@ struct dpu_mdss_cfg {
>   	const struct dpu_wb_cfg *wb;
>   
>   	u32 reg_dma_count;
> -	struct dpu_reg_dma_cfg dma_cfg;
> +	const struct dpu_reg_dma_cfg *dma_cfg;
>   
>   	u32 ad_count;
>