(c->state) is u32, (enable) is bool. It returns false when (c->state) > 1 and (enable) is true. Convert (c->state) to bool. Signed-off-by: Li Zhengyu <lizhengyu3@xxxxxxxxxx> --- drivers/clk/qcom/clk-rpmh.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/qcom/clk-rpmh.c b/drivers/clk/qcom/clk-rpmh.c index aed907982344..851e127432a9 100644 --- a/drivers/clk/qcom/clk-rpmh.c +++ b/drivers/clk/qcom/clk-rpmh.c @@ -196,7 +196,7 @@ static int clk_rpmh_aggregate_state_send_command(struct clk_rpmh *c, int ret; /* Nothing required to be done if already off or on */ - if (enable == c->state) + if (enable == !!c->state) return 0; c->state = enable ? c->valid_state_mask : 0; -- 2.17.1
