On Thu, May 26, 2022 at 07:47:40PM +0530, Sireesh Kodali wrote: > The smem-state properties for the pronto node were incorrectly labelled, > reading `qcom,state*` rather than `qcom,smem-state*`. Fix that, allowing > the stop state to be used. > > Fixes: 88106096cbf8 ("ARM: dts: msm8916: Add and enable wcnss node") > Signed-off-by: Sireesh Kodali <sireeshkodali1@xxxxxxxxx> My review didn't change just because of an unneeded blank line between the tags. Thanks again for finding this. :) Reviewed-by: Stephan Gerhold <stephan@xxxxxxxxxxx> > --- > arch/arm64/boot/dts/qcom/msm8916.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi > index e34963505e07..7ecd747dc624 100644 > --- a/arch/arm64/boot/dts/qcom/msm8916.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi > @@ -1758,8 +1758,8 @@ pronto: remoteproc@a21b000 { > <&rpmpd MSM8916_VDDMX>; > power-domain-names = "cx", "mx"; > > - qcom,state = <&wcnss_smp2p_out 0>; > - qcom,state-names = "stop"; > + qcom,smem-states = <&wcnss_smp2p_out 0>; > + qcom,smem-state-names = "stop"; > > pinctrl-names = "default"; > pinctrl-0 = <&wcnss_pin_a>; > -- > 2.36.1 >