Hi Linus, Thank you for the review. On Tue, May 24, 2022 at 9:57 AM Linus Walleij <linus.walleij@xxxxxxxxxx> wrote: > > On Mon, May 23, 2022 at 7:43 PM Lad Prabhakar > <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> wrote: > > > Add IRQ domain to RZ/G2L pinctrl driver to handle GPIO interrupt. > > > > GPIO0-GPIO122 pins can be used as IRQ lines but only 32 pins can be > > used as IRQ lines at a given time. Selection of pins as IRQ lines > > is handled by IA55 (which is the IRQC block) which sits in between the > > GPIO and GIC. > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > > I don't know if I'm too tired or reading it wrong, but it seems you > went through the trouble of making it possible to override .free() in > the irqdomain in patch 3/5 and yet not using it in this patch 5/5? > I think you missed it, free callback is overridden with rzg2l_gpio_irq_domain_free(). [0] https://patchwork.kernel.org/project/linux-renesas-soc/patch/20220523174238.28942-6-prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx/ Cheers, Prabhakar
