On Mon, May 23, 2022 at 4:44 AM Suzuki K Poulose <suzuki.poulose@xxxxxxx> wrote: > > Cc: Rob Herring > Will or will not have any effect... Please use get_maintainers.pl and send your patches to the right lists/maintainers. DT patches only get reviewed if sent to DT list. So please resend to the DT list. But before you do, I can tell this binding hasn't been tested so fix all the warnings first. Rob > > > On 09/05/2022 14:39, Mao Jinlong wrote: > > Adds new coresight-tpda.yaml file describing the bindings required > > to define tpda in the device trees. > > > > Reviewed-by: Mike Leach <mike.leach@xxxxxxxxxx> > > Signed-off-by: Tao Zhang <quic_taozha@xxxxxxxxxxx> > > Signed-off-by: Mao Jinlong <quic_jinlmao@xxxxxxxxxxx> > > --- > > .../bindings/arm/coresight-tpda.yaml | 119 ++++++++++++++++++ > > MAINTAINERS | 1 + > > 2 files changed, 120 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/arm/coresight-tpda.yaml > > > > diff --git a/Documentation/devicetree/bindings/arm/coresight-tpda.yaml b/Documentation/devicetree/bindings/arm/coresight-tpda.yaml > > new file mode 100644 > > index 000000000000..4948ac13e7f8 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/arm/coresight-tpda.yaml > > @@ -0,0 +1,119 @@ > > +# SPDX-License-Identifier: GPL-2.0-only or BSD-2-Clause > > +# Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved. > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/arm/coresight-tpda.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Trace, Profiling and Diagnostics Aggregator - TPDA > > + > > +description: | > > + TPDAs are responsible for packetization and timestamping of data sets > > + utilizing the MIPI STPv2 packet protocol. Pulling data sets from one or > > + more attached TPDM and pushing the resultant (packetized) data out a > > + master ATB interface. Performing an arbitrated ATB interleaving (funneling) > > + task for free-flowing data from TPDM (i.e. CMB and DSB data set flows). > > + > > +maintainers: > > + - Mao Jinlong <quic_jinlmao@xxxxxxxxxxx> > > + - Tao Zhang <quic_taozha@xxxxxxxxxxx> > > + > > +properties: > > + $nodename: > > + pattern: "^tpda(@[0-9a-f]+)$" > > + compatible: > > + items: > > + - const: qcom,coresight-tpda > > + - const: arm,primecell > > + > > + reg: > > + maxItems: 1 > > + > > + clocks: > > + maxItems: 1 > > + > > + clock-names: > > + items: > > + - const: apb_pclk > > + > > + in-ports: > > + type: object > > + description: | > > + Input connections from TPDM to TPDA > > + $ref: /schemas/graph.yaml#/properties/ports > > + > > --->8--- > > + properties: > > + '#address-cells': > > + const: 1 > > + > > + '#size-cells': > > + const: 0 > > + > > + patternProperties: > > + "^port@[0-9a-f]+$": > > + type: object > > + required: > > + - reg > > + > > + required: > > + - '#size-cells' > > + - '#address-cells' > > ---8<--- > > I believe the above snippet is not needed and is covered by the generic > ports. > > > > + > > + out-ports: > > + type: object > > + description: | > > + Output connections from the TPDA to legacy CoreSight trace bus. > > + $ref: /schemas/graph.yaml#/properties/ports > > + > > + properties: > > + port: > > + description: > > + Output connection from the TPDA to legacy CoreSight Trace bus. > > + $ref: /schemas/graph.yaml#/properties/port > > + > > +required: > > + - compatible > > + - reg > > + - clocks > > + - clock-names > > + - in-ports > > + - out-ports > > + > > +additionalProperties: false > > + > > +examples: > > + # minimum tpda definition. > > + - | > > + tpda@6004000 { > > + compatible = "qcom,coresight-tpda", "arm,primecell"; > > + reg = <0x6004000 0x1000>; > > + > > + qcom,tpda-atid = <65>; > > + > > + clocks = <&aoss_qmp>; > > + clock-names = "apb_pclk"; > > + > > + in-ports { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + port@0 { > > + reg = <0>; > > + tpda_qdss_0_in_tpdm_dcc: endpoint { > > + remote-endpoint = > > + <&tpdm_dcc_out_tpda_qdss_0>; > > + }; > > + }; > > + }; > > + > > + out-ports { > > + port { > > + tpda_qdss_out_funnel_in0: endpoint { > > + remote-endpoint = > > + <&funnel_in0_in_tpda_qdss>; > > + }; > > + }; > > + }; > > + }; > > + > > +... > > diff --git a/MAINTAINERS b/MAINTAINERS > > index 28d32b3f3f5c..5d2d8c0ee340 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -1978,6 +1978,7 @@ T: git git://git.kernel.org/pub/scm/linux/kernel/git/coresight/linux.git > > F: Documentation/ABI/testing/sysfs-bus-coresight-devices-* > > F: Documentation/devicetree/bindings/arm/coresight-cpu-debug.txt > > F: Documentation/devicetree/bindings/arm/coresight-cti.yaml > > +F: Documentation/devicetree/bindings/arm/coresight-tpda.yaml > > F: Documentation/devicetree/bindings/arm/coresight-tpdm.yaml > > F: Documentation/devicetree/bindings/arm/coresight.txt > > F: Documentation/devicetree/bindings/arm/ete.yaml > > Otherwise looks good to me. > > Suzuki
