Quoting Doug Anderson (2022-05-20 15:16:03) > On Tue, Apr 26, 2022 at 7:03 PM Stephen Boyd <swboyd@xxxxxxxxxxxx> wrote: > > arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom.dtsi | 1 - > > arch/arm64/boot/dts/qcom/sc7180-trogdor-r1.dts | 1 - > > arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 3 ++- > > 19 files changed, 17 insertions(+), 19 deletions(-) > > While reviewing a different change, I found something fishy and > tracked it down to ${SUBJECT} patch. > > Specifically, after ${SUBJECT} patch then I run `git grep > include.*trogdor.dtsi`. When I do that, I see that > `sc7180-trogdor.dtsi` is double-included in all lazor devices. :( It's > included in the actual dts files and also in the lazor.dtsi file. > > That's probably not right. I think we need to remove the one in the > lazor.dtsi file? > Good catch! I sent a patch to fix it[1]. I recall I compiled before/after and didn't see any difference, so I suspect it's just a waste of time during the compilation phase but otherwise not causing a problem. [1] https://lore.kernel.org/r/20220520231355.1559104-1-swboyd@xxxxxxxxxxxx