Hi, On Fri, May 20, 2022 at 9:10 AM Judy Hsiao <judyhsiao@xxxxxxxxxxxx> wrote: > > 1. Add drive strength property for mi2s1 on sc7280 based platforms. > 2. Disbale the pull-up mi2s1_data0, mi2s1_sclk. > > Signed-off-by: Judy Hsiao <judyhsiao@xxxxxxxxxxxx> > --- > arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi > index 9cb1bc8ed6b5..6d8744e130b0 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi > @@ -612,6 +612,20 @@ &dp_hot_plug_det { > bias-disable; > }; > > +&mi2s1_data0 { > + drive-strength = <6>; > + bias-disable; > +}; > + > +&mi2s1_sclk { > + drive-strength = <6>; > + bias-disable; > +}; > + > +&mi2s1_ws { > + drive-strength = <6>; > +}; I'm actually curious why this line has a drive-strength but _no_ bias setting. I guess I should figure out what the heck "ws" is. Ah, I guess it is word select. Since this is an output I'd expect to see "bias-disable" here too. -Doug