Re: [PATCH v6 2/5] clk: qcom: regmap: add PHY clock source implementation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 18/05/2022 10:48, Johan Hovold wrote:
On Wed, May 18, 2022 at 09:34:19AM +0200, Johan Hovold wrote:
On Fri, May 13, 2022 at 08:53:36PM +0300, Dmitry Baryshkov wrote:

+/*
+ * A special clock implementation for PHY pipe and symbols clock sources.

s/sources/muxes/

+ *
+ * If the clock is running off the from-PHY source, report it as enabled.
+ * Report it as disabled otherwise (if it uses reference source).
+ *
+ * This way the PHY will disable the pipe clock before turning off the GDSC,

s|pipe|pipe/symbol|

+ * which in turn would lead to disabling corresponding pipe_clk_src (and thus
+ * it being parked to a safe, reference clock source). And vice versa, after
+ * enabling the GDSC the PHY will enable the pipe clock, which would cause

s|pipe|pipe/symbol|

+ * pipe_clk_src to be switched from a safe source to the working one.
+ */

You're still referring to the old pipe_clk_src name in two places in
this comment.

Just remembered that the PCIe/USB mux is also referred to as
pipe_clk_src and that your not referring to the clock implementation.

I guess the comment works as-is even if the example refers to just
USB/PCIe.

I will add a phrase mentioning UFS symbol clocks.


Should this be reflected in Subject as well (e.g. "PHY mux
implementation")?

Johan


--
With best wishes
Dmitry



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux