Fix the missing clk_disable_unprepare() before return from qcom_pcie2_phy_power_on() in the error handling case. Signed-off-by: Peng Wu <wupeng58@xxxxxxxxxx> --- drivers/phy/qualcomm/phy-qcom-pcie2.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/phy/qualcomm/phy-qcom-pcie2.c b/drivers/phy/qualcomm/phy-qcom-pcie2.c index 5407e59bb185..1cc8145e0811 100644 --- a/drivers/phy/qualcomm/phy-qcom-pcie2.c +++ b/drivers/phy/qualcomm/phy-qcom-pcie2.c @@ -162,8 +162,10 @@ static int qcom_pcie2_phy_power_on(struct phy *phy) ret = readl_poll_timeout(qphy->base + PCIE20_PARF_PHY_STTS, val, !(val & BIT(0)), 1000, 10); - if (ret) + if (ret) { + clk_disable_unprepare(qphy->pipe_clk); dev_err(qphy->dev, "phy initialization failed\n"); + } out: return ret; -- 2.17.1