Dear Mani,
Got it, thank you very much.
Best regards.
-----邮件原件-----
发件人: Manivannan Sadhasivam <mani@xxxxxxxxxx>
发送时间: 2022年5月13日 16:43
收件人: Yonglin Tan <yonglin.tan@xxxxxxxxxxx>
抄送: mani@xxxxxxxxxx; quic_hemantk@xxxxxxxxxxx; gregkh@xxxxxxxxxxxxxxxxxxx; loic.poulain@xxxxxxxxxx; mhi@xxxxxxxxxxxxxxx; linux-arm-msm@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
主题: Re: [PATCH] bus: mhi: host: Add support for Quectel EM120 FCCL project.
On Fri, May 13, 2022 at 03:00:25PM +0800, Yonglin Tan wrote:
> From: ylintan <yonglin.tan@xxxxxxxxxxx>
>
> This patch add VendorID/DeviceID definitions for EM120 FCCL project.
> It has the same configration as Quectel EM160R-GL and EM120R-GL.
>
> Reviewed-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Reviewed-by: Hemant Kumar <hemantk@xxxxxxxxxxxxxx>
> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx>
> Signed-off-by: Yonglin Tan <yonglin.tan@xxxxxxxxxxx>
On top of what Greg said, you don't need to CC Greg for MHI patches. I will review and apply the patches to MHI tree and submit a cumulative PR to Greg.
Let's give some air to him ;)
Thanks,
Mani
> ---
> drivers/bus/mhi/host/pci_generic.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/bus/mhi/host/pci_generic.c
> b/drivers/bus/mhi/host/pci_generic.c
> index 8416267..0a6469c 100644
> --- a/drivers/bus/mhi/host/pci_generic.c
> +++ b/drivers/bus/mhi/host/pci_generic.c
> @@ -557,6 +557,8 @@ static const struct pci_device_id mhi_pci_id_table[] = {
> .driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
> { PCI_DEVICE(0x1eac, 0x1002), /* EM160R-GL (sdx24) */
> .driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
> + { PCI_DEVICE(0x1eac, 0x2001), /* EM120R-GL for FCCL (sdx24) */
> + .driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
> /* T99W175 (sdx55), Both for eSIM and Non-eSIM */
> { PCI_DEVICE(PCI_VENDOR_ID_FOXCONN, 0xe0ab),
> .driver_data = (kernel_ulong_t) &mhi_foxconn_sdx55_info },
> --
> 2.7.4
>
>
--
மணிவண்ணன் சதாசிவம்
