Quoting Bjorn Andersson (2022-05-04 09:53:54) > On Tue 12 Apr 14:45 CDT 2022, Stephen Boyd wrote: > > > Set the wake and sleep state for BCM clks here, not just the active > > state, as the active only state is dropped when CPUs go to deep idle. > > This ensures the clk is always on when the driver thinks it is on. > > > > This was found by inspection, and could very well be incorrect if the > > RPMh hardware copies over the active only state to the sleep and wake > > states. > > > > Taking another look at this patch and now it makes perfect sense to me. > Sorry for not grasping the problem earlier. > > Reviewed-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx> > > > Will you take this in fixes, or do you want me to pick it for 5.19? > I'm waiting for Taniya to reply. For all I know this has no effect because there's some sort of copy/paste from one state to another. Until then it doesn't seem like we should do anything.
