On 04/05/2022 17:37, Rob Herring wrote: > On Wed, May 04, 2022 at 02:51:19PM +0200, Krzysztof Kozlowski wrote: >> Recent Qualcomm Geni SPI nodes, e.g. on SM8450, come with three >> interconnects. This fixes dtbs_check warnings like: >> >> sm8450-qrd.dtb: geniqup@8c0000: spi@880000:interconnect-names: ['qup-core', 'qup-config'] is too short > > I'm confused. A length of 2 was already allowed before this change. Me too... I think I copied that message not from original code, but from intermediary fix setting it to three elements. This was also wrong because some of nodes have two some three interconnects. The actual error is: arch/arm64/boot/dts/qcom/sm8450-qrd.dtb: spi@a98000: interconnects: [[46, 1, 0, 46, 4, 0], [47, 2, 0, 48, 12, 0], [49, 1, 0, 50, 1, 0]] is too long From schema: Documentation/devicetree/bindings/spi/qcom,spi-geni-qcom.yaml arch/arm64/boot/dts/qcom/sm8450-qrd.dtb: spi@a98000: interconnect-names: ['qup-core', 'qup-config', 'qup-memory'] is too long From schema: Documentation/devicetree/bindings/spi/qcom,spi-geni-qcom.yaml I will send a v2. Best regards, Krzysztof
