On Tue, 3 May 2022 at 17:01, Bjorn Andersson <bjorn.andersson@xxxxxxxxxx> wrote: > > On Tue 03 May 08:04 CDT 2022, Robert Foss wrote: > > > From: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx> > > > > As GDSCs are turned on and off some associated clocks are momentarily > > enabled for house keeping purposes. Failure to enable these clocks seems > > to have been silently ignored in the past, but starting in SM8350 this > > failure will prevent the GDSC to turn on. > > > > At least on SM8350 this operation will enable the RCG per the > > configuration in CFG_REG. This means that the current model where the > > current configuration is written back to CF_REG immediately after > > parking the RCG doesn't work. > > > > Instead, keep track of the currently requested rate of the clock and > > upon enabling the clock reapply the configuration per the saved rate. > > > > Fixes: 7ef6f11887bd ("clk: qcom: Configure the RCGs to a safe source as needed") > > Signed-off-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx> > > Reviewed-by: Vinod Koul <vkoul@xxxxxxxxxx> > > Tested-by: Steev Klimaszewski <steev@xxxxxxxx> > > --- > > This patch has been iterated since and the latest incarnation can be > found on below link. A reference to that in the cover letter would be > sufficient. > > https://lore.kernel.org/linux-arm-msm/20220426212136.1543984-1-bjorn.andersson@xxxxxxxxxx/ > Will do, thanks!