On 29/04/2022 15:01, Ansuel Smith wrote:
Check if hw_parent is present before calculating the round_rate to
prevent kernel panic. On error -EINVAL is reported.
Signed-off-by: Ansuel Smith <ansuelsmth@xxxxxxxxx>
I see that other clock drivers do not perform this check. Which path
leads to this oops?
---
drivers/clk/qcom/clk-krait.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/clk/qcom/clk-krait.c b/drivers/clk/qcom/clk-krait.c
index 90046428693c..6c367ad6506a 100644
--- a/drivers/clk/qcom/clk-krait.c
+++ b/drivers/clk/qcom/clk-krait.c
@@ -84,7 +84,12 @@ EXPORT_SYMBOL_GPL(krait_mux_clk_ops);
static long krait_div2_round_rate(struct clk_hw *hw, unsigned long rate,
unsigned long *parent_rate)
{
- *parent_rate = clk_hw_round_rate(clk_hw_get_parent(hw), rate * 2);
+ struct clk_hw *hw_parent = clk_hw_get_parent(hw);
+
+ if (!hw_parent)
+ return -EINVAL;
+
+ *parent_rate = clk_hw_round_rate(hw_parent, rate * 2);
return DIV_ROUND_UP(*parent_rate, 2);
}
--
With best wishes
Dmitry
